RESOLVED FIXED 29191
Add implementation of texImage2D that takes CanvasArray 
https://bugs.webkit.org/show_bug.cgi?id=29191
Summary Add implementation of texImage2D that takes CanvasArray
Chris Marrin
Reported 2009-09-11 10:03:35 PDT
This is part of the spec not currently implemented
Attachments
Patch (4.22 KB, patch)
2009-09-11 10:19 PDT, Chris Marrin 		oliver: review-
DetailsFormatted DiffDiff
Replacement patch (4.93 KB, patch)
2009-09-11 11:23 PDT, Chris Marrin 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2009-09-11 10:19:26 PDT
Created attachment 39447 [details] Patch
Oliver Hunt
Comment 2 2009-09-11 10:56:39 PDT
Comment on attachment 39447 [details] Patch > + unsigned internalformat = args.at(2).toInt32(exec); > + unsigned width = args.at(3).toInt32(exec); > + unsigned height = args.at(4).toInt32(exec); > + unsigned border = args.at(5).toInt32(exec); > + unsigned format = args.at(6).toInt32(exec); > + unsigned type = args.at(7).toInt32(exec); > + CanvasArray* array = toCanvasArray(args.at(8)); You have no guarantee that this is actually a canvas array, so you need to do a type check and throw a typeerror or whatever. Additionally all of these conversions can throw exceptions so *technically* there should be an exception check following each one.
Chris Marrin
Comment 3 2009-09-11 11:23:56 PDT
Created attachment 39453 [details] Replacement patch
Oliver Hunt
Comment 4 2009-09-11 11:26:48 PDT
Comment on attachment 39453 [details] Replacement patch r=me
Chris Marrin
Comment 5 2009-09-11 11:31:52 PDT
Sending WebCore/ChangeLog Sending WebCore/bindings/js/JSCanvasRenderingContext3DCustom.cpp Sending WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp Transmitting file data ... Committed revision 48310.
Note You need to log in before you can comment on or make changes to this bug.