RESOLVED FIXED291770
Standardize on move arguments for ResourceRequest and ResourceResponse 
https://bugs.webkit.org/show_bug.cgi?id=291770
Summary Standardize on move arguments for ResourceRequest and ResourceResponse
Brent Fulgham
Reported 2025-04-18 14:20:21 PDT
In Bug 291754 and Bug 291589 we added move parameters to various methods. This resulted in code duplication. Instead, standardize on move parameters and explicitly perform copies at the relevant call sites. This helps us find missing move opportunities, and helps us see API where a lot of copying is needed.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2025-04-18 15:30:26 PDT
<rdar://problem/149577600>
Brent Fulgham
Comment 2 2025-04-18 15:38:34 PDT
Pull request: https://github.com/WebKit/WebKit/pull/44275
EWS
Comment 3 2025-04-23 17:23:04 PDT
Committed 294030@main (178f41b935d4): <https://commits.webkit.org/294030@main> Reviewed commits have been landed. Closing PR #44275 and removing active labels.
Ben Schwartz
Comment 4 2025-04-23 19:35:09 PDT
Reopened Bugzilla. 294030@main broke internal builds, tracking revert in https://bugs.webkit.org/show_bug.cgi?id=291991.
Brent Fulgham
Comment 5 2025-04-24 12:55:10 PDT
Pull request: https://github.com/WebKit/WebKit/pull/44478
EWS
Comment 6 2025-04-24 13:48:32 PDT
Committed 294079@main (b02503697e0b): <https://commits.webkit.org/294079@main> Reviewed commits have been landed. Closing PR #44478 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.