Bug 29175 - JavaScriptCore: corrects build break on sparc 64 with gcc
Summary: JavaScriptCore: corrects build break on sparc 64 with gcc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 03:09 PDT by Jocelyn Turcotte
Modified: 2009-09-11 06:29 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.80 KB, patch)
2009-09-11 03:09 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch v0.2 (2.12 KB, patch)
2009-09-11 05:39 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2009-09-11 03:09:01 PDT
Created attachment 39420 [details]
Patch

Compiling JavaScriptCore on sparc 64 with gcc fails.

ThreadSafeShared uses the atomic __gnu_cxx::__exchange_and_add with an int, however on sparc 64 the _Atomic_word argument is typedefed to long (8 bytes).

The patch disables WTF_USE_LOCKFREE_THREADSAFESHARED in ThreadSafeShared to use a mutex instead when compiling for sparc 64 with gcc.
Comment 1 Jocelyn Turcotte 2009-09-11 05:39:10 PDT
Created attachment 39423 [details]
Patch v0.2

Copy but patch description into changelog
Comment 2 Simon Hausmann 2009-09-11 05:40:53 PDT
Comment on attachment 39423 [details]
Patch v0.2

r=me
Comment 3 WebKit Commit Bot 2009-09-11 06:29:37 PDT
Comment on attachment 39423 [details]
Patch v0.2

Clearing flags on attachment: 39423

Committed r48300: <http://trac.webkit.org/changeset/48300>
Comment 4 WebKit Commit Bot 2009-09-11 06:29:49 PDT
All reviewed patches have been landed.  Closing bug.