RESOLVED FIXED 29173
[GTK] Use gtk_style_set_background instead of gdk_window_set_background 
https://bugs.webkit.org/show_bug.cgi?id=29173
Summary [GTK] Use gtk_style_set_background instead of gdk_window_set_background
Xan Lopez
Reported 2009-09-11 02:07:21 PDT
Explanation in the patch.
Attachments
setbackground.diff (2.23 KB, patch)
2009-09-11 02:09 PDT, Xan Lopez 		jmalonzo: review+
xan.lopez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2009-09-11 02:09:52 PDT
Created attachment 39417 [details] setbackground.diff
Jan Alonzo
Comment 2 2009-09-11 03:58:52 PDT
Comment on attachment 39417 [details] setbackground.diff Are there any visible changes to this? If so can we have a test (manual or otherwise)?
Xan Lopez
Comment 3 2009-09-11 04:03:09 PDT
(In reply to comment #2) > (From update of attachment 39417 [details]) > Are there any visible changes to this? If so can we have a test (manual or > otherwise)? Not really, gtk_style_set_background will just call the same function we were using. The difference is that it also takes into account pixmap backgrounds, so it's safer to use it.
Jan Alonzo
Comment 4 2009-09-11 15:27:23 PDT
Comment on attachment 39417 [details] setbackground.diff r=me.
Xan Lopez
Comment 5 2009-09-11 23:55:30 PDT
Landed in r48332.
Note You need to log in before you can comment on or make changes to this bug.