Bug 29173 - [GTK] Use gtk_style_set_background instead of gdk_window_set_background
Summary: [GTK] Use gtk_style_set_background instead of gdk_window_set_background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 02:07 PDT by Xan Lopez
Modified: 2009-09-11 23:55 PDT (History)
0 users

See Also:

Attachments
setbackground.diff (2.23 KB, patch)
2009-09-11 02:09 PDT, Xan Lopez 		jmalonzo: review+
xan.lopez: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-09-11 02:07:21 PDT 
Explanation in the patch.
Comment 1 Xan Lopez 2009-09-11 02:09:52 PDT 
Created attachment 39417 [details]
setbackground.diff
Comment 2 Jan Alonzo 2009-09-11 03:58:52 PDT 
Comment on attachment 39417 [details]
setbackground.diff

Are there any visible changes to this? If so can we have a test (manual or otherwise)?
Comment 3 Xan Lopez 2009-09-11 04:03:09 PDT 
(In reply to comment #2)
> (From update of attachment 39417 [details])
> Are there any visible changes to this? If so can we have a test (manual or
> otherwise)?

Not really, gtk_style_set_background will just call the same function we were using. The difference is that it also takes into account pixmap backgrounds, so it's safer to use it.
Comment 4 Jan Alonzo 2009-09-11 15:27:23 PDT 
Comment on attachment 39417 [details]
setbackground.diff

r=me.
Comment 5 Xan Lopez 2009-09-11 23:55:30 PDT 
Landed in r48332.