Bug 29171 - Platform code to support WebSocket for chromium.
Summary: Platform code to support WebSocket for chromium.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-11 01:18 PDT by Fumitoshi Ukai
Modified: 2009-09-29 02:03 PDT (History)
2 users (show)

See Also:

Attachments
platform code to support WebSocket for chromium (10.45 KB, patch)
2009-09-11 03:08 PDT, Fumitoshi Ukai 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fumitoshi Ukai 2009-09-11 01:18:50 PDT 
Platform code to support WebSocket for chromium.
Add SocketStreamHandle in WebCore/platform/chromium.
Comment 1 Fumitoshi Ukai 2009-09-11 03:08:49 PDT 
Created attachment 39419 [details]
platform code to support WebSocket for chromium


---
 4 files changed, 160 insertions(+), 0 deletions(-)
Comment 2 Adam Barth 2009-09-23 22:21:18 PDT 
Comment on attachment 39419 [details]
platform code to support WebSocket for chromium

Nit:

+ static PassRefPtr<SocketStreamHandle> create(const KURL& url, SocketStreamHandleClient* client)

No need for argument names here.
Comment 3 Fumitoshi Ukai 2009-09-24 00:54:52 PDT 
Thanks for review!

(In reply to comment #2)
> (From update of attachment 39419 [details])
> Nit:
> 
> + static PassRefPtr<SocketStreamHandle> create(const KURL& url,
> SocketStreamHandleClient* client)
> 
> No need for argument names here.

I think these are necessary because these arguments are used in inline function body.
Comment 4 Eric Seidel (no email) 2009-09-24 13:52:13 PDT 
It looks like Fumitoshi was invited to be a committer 9 days ago, but I do not know if he has his credentials yet.  Leaving this for him to commit or set commit-queue? if necessary.
Comment 5 Fumitoshi Ukai 2009-09-28 23:05:31 PDT 
Landed.
Thanks for review!
Comment 6 Fumitoshi Ukai 2009-09-29 02:03:26 PDT 
(In reply to comment #5)
> Landed.
Landed as r48859.

> Thanks for review!