Bug 29169 - [GTK] EventSender does not set 'window' property on synthesized GDK events
Summary: [GTK] EventSender does not set 'window' property on synthesized GDK events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-10 22:21 PDT by Martin Robinson
Modified: 2009-09-13 03:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch for this issue (6.14 KB, patch)
2009-09-10 22:25 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch for this issue (rev2) (6.17 KB, patch)
2009-09-11 08:27 PDT, Martin Robinson 		jmalonzo: review+
jmalonzo: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2009-09-10 22:21:58 PDT 
I noticed another issue with EventSender events tonight (for some reason this did not manifest before). The synthesized GDK events do not set the 'window' property. Some event handling routines require this, in particular gtk_im_context_filter_keypress.
Comment 1 Martin Robinson 2009-09-10 22:25:27 PDT 
Created attachment 39410 [details]
Patch for this issue

I've attached a patch for this issue.
Comment 2 Xan Lopez 2009-09-11 00:38:16 PDT 
Comment on attachment 39410 [details]
Patch for this issue

Even though in this case it will be the same thing, I think it's more straightforward to use the widget's window instead of the parent's window, right?
Comment 3 Martin Robinson 2009-09-11 08:27:01 PDT 
Created attachment 39435 [details]
Patch for this issue (rev2)

Very much so. What a silly mistake. :) I've attached a new patch.
Comment 4 Jan Alonzo 2009-09-11 17:08:10 PDT 
Comment on attachment 39435 [details]
Patch for this issue (rev2)

r=me.
Comment 5 Jan Alonzo 2009-09-13 03:25:31 PDT 
(In reply to comment #4)
> (From update of attachment 39435 [details])
> r=me.

Landed as http://trac.webkit.org/changeset/48342.