Test case: LayoutTests\svg\W3C-SVG-1.1\interact-order-03-b.svg Could not select heyperlinked text. The expected selection result is demoed in attachment.
Created attachment 39404 [details] The expected selection of a hyperlinked text.
It is possible these days to select the text in the hyperlink these days, so this bug seems fixed now. Can anybody confirm? Note that HTMLAnchorElement::canStartSelection has this FIXME: // FIXME: We probably want this same behavior in SVGAElement too The behaviour is to not allow the text in the hyperlink to start a selection, but still allow selection of the text in the hyperlink when the selection started from outside the hyperlink. Do we want this? For now I'll make use of this bug to post a refactor patch. If we want to add above behaviour that would be easy to add.
Created attachment 146703 [details] Patch
Comment on attachment 146703 [details] Patch LGTM.
Comment on attachment 146703 [details] Patch Rejecting attachment 146703 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: et -4 lines). patching file Source/WebCore/html/HTMLAnchorElement.cpp Hunk #1 FAILED at 569. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLAnchorElement.cpp.rej patching file Source/WebCore/html/HTMLAnchorElement.h Hunk #1 succeeded at 157 (offset 2 lines). patching file Source/WebCore/svg/SVGAElement.cpp Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13403765
(In reply to comment #5) > (From update of attachment 146703 [details]) > Rejecting attachment 146703 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > et -4 lines). > patching file Source/WebCore/html/HTMLAnchorElement.cpp > Hunk #1 FAILED at 569. > 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLAnchorElement.cpp.rej > patching file Source/WebCore/html/HTMLAnchorElement.h > Hunk #1 succeeded at 157 (offset 2 lines). > patching file Source/WebCore/svg/SVGAElement.cpp > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/13403765 That was to be expected :) I can land his and the other SVG patch tomorrow. Cheers, Rob.
Patch landed in r124538. Closing since the original problem is fixed too since a while.