Bug 29165 - Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
Summary: Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-10 17:23 PDT by Cameron McCormack (:heycam)
Modified: 2009-09-11 02:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (4.06 KB, patch)
2009-09-10 17:31 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2009-09-10 17:23:54 PDT 
CodeGeneratorV8.pm has its own copies of WK_ucfirst and WK_lcfirst.  It should just call the ones in CodeGenerator.pm instead.
Comment 1 Cameron McCormack (:heycam) 2009-09-10 17:31:16 PDT 
Created attachment 39399 [details]
Patch v1

I note that the WK_lcfirst in CodeGenerator.pm is different from the one in CodeGeneratorV8.pm.  The only case that CodeGeneratorV8 calls WK_lcfirst for is the "URL" attribute on Document (and a couple of other interfaces), so there should be no change in output.  I inspected the output of running generate-bindings.pl on Document visually, but didn't build anything to test (I guess I'd need to check out Chromium to do that).
Comment 2 Eric Seidel (no email) 2009-09-10 17:55:44 PDT 
Comment on attachment 39399 [details]
Patch v1

You're a brave man. :)  I guess we'll just roll this out if you break the Chromium canary.
Comment 3 Dimitri Glazkov (Google) 2009-09-10 20:28:13 PDT 
This is a good clean-up. cam++.
Comment 4 WebKit Commit Bot 2009-09-11 02:03:06 PDT 
Comment on attachment 39399 [details]
Patch v1

Clearing flags on attachment: 39399

Committed r48292: <http://trac.webkit.org/changeset/48292>
Comment 5 WebKit Commit Bot 2009-09-11 02:03:10 PDT 
All reviewed patches have been landed.  Closing bug.