RESOLVED FIXED 29165
Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm 
https://bugs.webkit.org/show_bug.cgi?id=29165
Summary Remove duplicated WK_{u,l}cfirst subs from CodeGeneratorV8.pm
Cameron McCormack (:heycam)
Reported 2009-09-10 17:23:54 PDT
CodeGeneratorV8.pm has its own copies of WK_ucfirst and WK_lcfirst. It should just call the ones in CodeGenerator.pm instead.
Attachments
Patch v1 (4.06 KB, patch)
2009-09-10 17:31 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2009-09-10 17:31:16 PDT
Created attachment 39399 [details] Patch v1 I note that the WK_lcfirst in CodeGenerator.pm is different from the one in CodeGeneratorV8.pm. The only case that CodeGeneratorV8 calls WK_lcfirst for is the "URL" attribute on Document (and a couple of other interfaces), so there should be no change in output. I inspected the output of running generate-bindings.pl on Document visually, but didn't build anything to test (I guess I'd need to check out Chromium to do that).
Eric Seidel (no email)
Comment 2 2009-09-10 17:55:44 PDT
Comment on attachment 39399 [details] Patch v1 You're a brave man. :) I guess we'll just roll this out if you break the Chromium canary.
Dimitri Glazkov (Google)
Comment 3 2009-09-10 20:28:13 PDT
This is a good clean-up. cam++.
WebKit Commit Bot
Comment 4 2009-09-11 02:03:06 PDT
Comment on attachment 39399 [details] Patch v1 Clearing flags on attachment: 39399 Committed r48292: <http://trac.webkit.org/changeset/48292>
WebKit Commit Bot
Comment 5 2009-09-11 02:03:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.