RESOLVED FIXED291625
PAL_EXPORT not defined, WebKit_Internal can't be used as a clang module 
https://bugs.webkit.org/show_bug.cgi?id=291625
Summary PAL_EXPORT not defined, WebKit_Internal can't be used as a clang module
adrian_taylor
Reported 2025-04-16 05:53:28 PDT
Within Source/WebCore/PAL/pal/SessionID.h, PAL_EXPORT is used, despite a lack of #include <pal/ExportMacros.h> This is fine in normal WebKit builds, because -include config.h is provided on the command line, and config.h includes pal/ExportMacros.h. However, if any header is added to WebKitInternal.h which transitively refers through to SessionID.h, the clang module does not build, because clang modules do not apply -include directives. An easy fix here is just to add #include <pal/ExportMacros.h> to this file. I'll raise a PR to do that. We might want to do something more systematic to ensure that config.h is strictly config.
Attachments
Add attachment proposed patch, testcase, etc.
adrian_taylor
Comment 1 2025-04-16 05:57:58 PDT
Pull request: https://github.com/WebKit/WebKit/pull/44145
Radar WebKit Bug Importer
Comment 2 2025-04-23 05:54:12 PDT
<rdar://problem/149850888>
EWS
Comment 3 2025-05-09 12:33:08 PDT
Committed 294724@main (4be5782bd026): <https://commits.webkit.org/294724@main> Reviewed commits have been landed. Closing PR #44145 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.