Bug 29162 - [Qt] Fix comparison between signed and unsigned integer warnings
Summary: [Qt] Fix comparison between signed and unsigned integer warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-10 17:09 PDT by Laszlo Gombos
Modified: 2009-09-10 20:12 PDT (History)
0 users

See Also:


Attachments
proposed patch (11.29 KB, patch)
2009-09-10 17:13 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-09-10 17:09:08 PDT
The significance of this work is to make a step towards enforcing the same code
quality measures as other WebKit ports (most notably the mac port) so that
contributors focusing on a specific WebKit ports are less likely break other
ports because of the difference in quality requirements.
Comment 1 Laszlo Gombos 2009-09-10 17:13:13 PDT
Created attachment 39396 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2009-09-10 17:54:44 PDT
Comment on attachment 39396 [details]
proposed patch

LGTM.  You can cq+ or land yourself since you're a committer.
Comment 3 Laszlo Gombos 2009-09-10 20:12:06 PDT
Thanks Eric for the review.

Landed as http://trac.webkit.org/changeset/48280.