Bug 29159 - Undo r47992
Summary: Undo r47992
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-10 16:25 PDT by Evan Stade
Modified: 2009-09-11 14:52 PDT (History)
2 users (show)

See Also:


Attachments
revert (2.54 KB, patch)
2009-09-10 16:26 PDT, Evan Stade
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Stade 2009-09-10 16:25:30 PDT
Darin F has pointed out that we should just use RenderTheme::setCustomFocusRingColor(). This patch should only be committed after http://codereview.chromium.org/195059/show.
Comment 1 Evan Stade 2009-09-10 16:26:23 PDT
Created attachment 39391 [details]
revert
Comment 2 Darin Adler 2009-09-10 16:52:12 PDT
Comment on attachment 39391 [details]
revert

Rolling out a change normally doesn't require review. rs=me
Comment 3 Eric Seidel (no email) 2009-09-10 18:13:18 PDT
estade says this depends on some chromium change so it can't be commit-queued.
Comment 4 WebKit Commit Bot 2009-09-10 18:17:46 PDT
Comment on attachment 39391 [details]
revert

Rejecting patch 39391 from commit-queue.

estade@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.
Comment 5 Evan Stade 2009-09-11 14:11:21 PDT
Comment on attachment 39391 [details]
revert

ready for commit
Comment 6 WebKit Commit Bot 2009-09-11 14:34:18 PDT
Comment on attachment 39391 [details]
revert

Rejecting patch 39391 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 7 Eric Seidel (no email) 2009-09-11 14:35:46 PDT
We were bitten again by bug 28845. :(
media/controls-after-reload.html -> crashed

I'm working right now on making the error messages nicer.
Comment 8 WebKit Commit Bot 2009-09-11 14:52:33 PDT
Comment on attachment 39391 [details]
revert

Clearing flags on attachment: 39391

Committed r48317: <http://trac.webkit.org/changeset/48317>
Comment 9 WebKit Commit Bot 2009-09-11 14:52:38 PDT
All reviewed patches have been landed.  Closing bug.