Bug 29152 – [v8] inline WebCore::v8String

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[anton muhin]

Inline WebCore::v8String---it's short enough.

[anton muhin]

Created attachment 39383 [details]
First pass

[WebKit Commit Bot]

Comment on attachment 39383 [details]
First pass

Rejecting patch 39383 from commit-queue.

This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39383 from bug 29152 failed to download and apply.

[Eric Seidel (no email)]

Looks like this patch does not have full paths in it.  Make sure you use svn-create-patch to create your patches.  Although it's possible you're hitting bug 29112.

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: bindings/v8/V8Binding.cpp
|===================================================================
|--- bindings/v8/V8Binding.cpp	(revision 48239)
|+++ bindings/v8/V8Binding.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: bindings/v8/V8Binding.h
|===================================================================
|--- bindings/v8/V8Binding.h	(revision 48239)
|+++ bindings/v8/V8Binding.h	(working copy)
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored

[anton muhin]

Created attachment 39424 [details]
Hopefully right paths

[anton muhin]

(In reply to comment #3)
> Looks like this patch does not have full paths in it.  Make sure you use
> svn-create-patch to create your patches.  Although it's possible you're hitting
> bug 29112.
> 
> can't find file to patch at input line 5
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Index: bindings/v8/V8Binding.cpp
> |===================================================================
> |--- bindings/v8/V8Binding.cpp    (revision 48239)
> |+++ bindings/v8/V8Binding.cpp    (working copy)
> --------------------------
> No file to patch.  Skipping patch.
> 1 out of 1 hunk ignored
> can't find file to patch at input line 5
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Index: bindings/v8/V8Binding.h
> |===================================================================
> |--- bindings/v8/V8Binding.h    (revision 48239)
> |+++ bindings/v8/V8Binding.h    (working copy)
> --------------------------
> No file to patch.  Skipping patch.
> 2 out of 2 hunks ignored

Eric, I do use svn-create-patch (in Chromium tree, on MacOS, with WebKitTools, separate WebKit checkout) and that's exactly the way it creates patches.  I raised this issue one, but currently don't have time to fix it myself.

This patch was produced with plain svn diff and, hopefully, has correct paths.

[WebKit Commit Bot]

Comment on attachment 39424 [details]
Hopefully right paths

Clearing flags on attachment: 39424

Committed r48301: <http://trac.webkit.org/changeset/48301>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.