Bug 29150 – [v8] create a real handler to JS objects when returning strings from StringImplCache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[anton muhin]

Currently, just a wrapper is created (v8::Local<v8::String>(pointer)) which won't save the object being handled if GC would happen (to be more precise, one mark flavours).  Let's use a proper local handle instead.

[anton muhin]

Created attachment 39376 [details]
First pass

[Adam Barth]

Comment on attachment 39376 [details]
First pass

I don't fully understand the V8 garbage collector, but this seems reasonable and I believe that you know what you're doing.  :)

[Adam Barth]

Comment on attachment 39376 [details]
First pass

I forgot that you aren't a committer yet.

[WebKit Commit Bot]

Comment on attachment 39376 [details]
First pass

Rejecting patch 39376 from commit-queue.

This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39376 from bug 29150 failed to download and apply.

[Eric Seidel (no email)]

Looks like somehow this patch is not from the root:
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: bindings/v8/V8Binding.cpp
|===================================================================
|--- bindings/v8/V8Binding.cpp	(revision 48239)
|+++ bindings/v8/V8Binding.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

[Mads Ager]

Looks good to me as well.  Good catch Anton.

[anton muhin]

Created attachment 39425 [details]
Hopefully right paths

Same story as with inlining patch.  Sorry all for inconvenience.

[WebKit Commit Bot]

Comment on attachment 39425 [details]
Hopefully right paths

Rejecting patch 39425 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

[anton muhin]

(In reply to comment #8)
> (From update of attachment 39425 [details])
> Rejecting patch 39425 from commit-queue.
> 
> This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests',
> '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit
> code 1

what should I do?  svn update and merge?

tia,
anton.

[Adam Barth]

Comment on attachment 39425 [details]
Hopefully right paths

This is likely a flaky test.  Let's try again.

[Eric Seidel (no email)]

Bitten by bug 28845. :(
compositing/color-matching/image-color-matching.html -> timed out

[WebKit Commit Bot]

Comment on attachment 39425 [details]
Hopefully right paths

Rejecting patch 39425 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

[Eric Seidel (no email)]

Comment on attachment 39425 [details]
Hopefully right paths

Just your lucky day. :(  Bug 28845 again!
compositing/self-painting-layers.html -> crashed

[WebKit Commit Bot]

Comment on attachment 39425 [details]
Hopefully right paths

Clearing flags on attachment: 39425

Committed r48305: <http://trac.webkit.org/changeset/48305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.