Bug 29143 - Added MathML toggle to build script
: Added MathML toggle to build script
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: Macintosh Intel Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
: 29158
  Show dependency treegraph
 
Reported: 2009-09-10 13:03 PST by
Modified: 2009-09-15 13:34 PST (History)


Attachments
Patch to add toggle flag to build script (1.86 KB, patch)
2009-09-10 13:04 PST, Alex Milowski
eric: review-
Review Patch | Details | Formatted Diff | Diff
Updated patch with tab removed (1.86 KB, patch)
2009-09-10 13:31 PST, Alex Milowski
mrowe: review-
Review Patch | Details | Formatted Diff | Diff
Updated patch with sorted order for additions (1.97 KB, patch)
2009-09-11 07:05 PST, Alex Milowski
vestbo: review-
Review Patch | Details | Formatted Diff | Diff
Updated patch with FeatureDefines.xcconfig changes included (9.22 KB, patch)
2009-09-15 13:17 PST, Alex Milowski
vestbo: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-10 13:03:36 PST
Added a toggle to the script to set the ENABLE_MATHML define.
------- Comment #1 From 2009-09-10 13:04:30 PST -------
Created an attachment (id=39369) [details]
Patch to add toggle flag to build script
------- Comment #2 From 2009-09-10 13:25:42 PST -------
(From update of attachment 39369 [details])
Doesn't ENABLE_ need to be added to http://trac.webkit.org/browser/trunk/WebCore/Configurations/FeatureDefines.xcconfig too?  I'm not sure what the rules are.  Mark Rowe (bdash) would know.
------- Comment #3 From 2009-09-10 13:26:10 PST -------
(From update of attachment 39369 [details])
Tabs in your ChangeLog will make this unlandable, r-
------- Comment #4 From 2009-09-10 13:31:10 PST -------
Created an attachment (id=39371) [details]
Updated patch with tab removed
------- Comment #5 From 2009-09-10 13:32:43 PST -------
I have another patch that will use the ENABLE_MATHML.  I don't see what an extra define that isn't used is going to hurt.  When I submit the CSS patch and rendering patches, it will be added to the WebCore/Configurations/FeatureDefines.xconfig file.
------- Comment #6 From 2009-09-10 22:18:40 PST -------
(From update of attachment 39371 [details])
The variable and option declarations are in alphabetical order.  The new variable and option should maintain that.  I think it would be best for MathML to be disabled by default until the implementation is more complete and tested.  Other than those minor issues, this change is fine.


Marking as r- as a revised patch will need to be posted before we can commit it.
------- Comment #7 From 2009-09-11 07:05:15 PST -------
Created an attachment (id=39429) [details]
Updated patch with sorted order for additions
------- Comment #8 From 2009-09-15 12:30:00 PST -------
(From update of attachment 39429 [details])
LGTM
------- Comment #9 From 2009-09-15 12:37:31 PST -------
(From update of attachment 39429 [details])
r- per bdash's comment about also updating FeatureDefines.xcconfig
------- Comment #10 From 2009-09-15 13:17:52 PST -------
Created an attachment (id=39612) [details]
Updated patch with FeatureDefines.xcconfig changes included
------- Comment #11 From 2009-09-15 13:24:06 PST -------
(From update of attachment 39612 [details])
r=me
------- Comment #12 From 2009-09-15 13:34:30 PST -------
Landed in r48400