RESOLVED FIXED 29141
Refactor StructureTransitionTable and Structure to unify handling of the single slot optimisation 
https://bugs.webkit.org/show_bug.cgi?id=29141
Summary Refactor StructureTransitionTable and Structure to unify handling of the sing...
Oliver Hunt
Reported 2009-09-10 12:17:06 PDT
Make code nice
Attachments
Patch v1 (15.99 KB, patch)
2009-09-10 12:22 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2009-09-10 12:22:40 PDT
Created attachment 39368 [details] Patch v1
Geoffrey Garen
Comment 2 2009-09-10 12:36:29 PDT
Please make the StructureTransitionTable() constructor call setSingleTransition(0), instead of handling the bitfield manually. Too bad we can't use PtrAndFlags here! We need a trick to help the leaks tool 'see' m_singleTransition. How about refactoring PtrAndFlags into a base class that has no constructor, and is safe to use in a union? r=me if you do those two things.
Oliver Hunt
Comment 3 2009-09-10 13:02:29 PDT
Committed r48264
Note You need to log in before you can comment on or make changes to this bug.