Bug 29141 - Refactor StructureTransitionTable and Structure to unify handling of the single slot optimisation
Summary: Refactor StructureTransitionTable and Structure to unify handling of the sing...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-10 12:17 PDT by Oliver Hunt
Modified: 2009-09-10 13:02 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (15.99 KB, patch)
2009-09-10 12:22 PDT, Oliver Hunt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-09-10 12:17:06 PDT
Make code nice
Comment 1 Oliver Hunt 2009-09-10 12:22:40 PDT
Created attachment 39368 [details]
Patch v1
Comment 2 Geoffrey Garen 2009-09-10 12:36:29 PDT
Please make the StructureTransitionTable() constructor call setSingleTransition(0), instead of handling the bitfield manually.

Too bad we can't use PtrAndFlags here! We need a trick to help the leaks tool 'see' m_singleTransition. How about refactoring PtrAndFlags into a base class that has no constructor, and is safe to use in a union?

r=me if you do those two things.
Comment 3 Oliver Hunt 2009-09-10 13:02:29 PDT
Committed r48264