WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29138
Simplify popup menu handling
https://bugs.webkit.org/show_bug.cgi?id=29138
Summary
Simplify popup menu handling
Anders Carlsson
Reported
2009-09-10 12:02:44 PDT
Currently, PopupMenu calls PopupMenuClient::hidePopup, when a popup menu needs to go away. The client method then hides the popup. The attached patch simplifies this so that calling PopupMenu::hide now hides the popup menu and then calls PopupMenuClient::popupDidHide.
Attachments
Patch
(11.79 KB, patch)
2009-09-10 12:05 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2009-09-10 12:05:58 PDT
Created
attachment 39364
[details]
Patch
Adam Roben (:aroben)
Comment 2
2009-09-10 13:35:56 PDT
Comment on
attachment 39364
[details]
Patch r=me
Eric Seidel (no email)
Comment 3
2009-09-18 13:21:25 PDT
Landed on Sept 14th as
r48370
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug