Bug 29136 - [Qt] emit microFocusChanged() signal when no QWidget-based view is present.
Summary: [Qt] emit microFocusChanged() signal when no QWidget-based view is present.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-10 11:59 PDT by Yongjun Zhang
Modified: 2009-09-11 01:56 PDT (History)
1 user (show)

See Also:


Attachments
emit microFocusChanged() regardless of view. (1.25 KB, patch)
2009-09-10 12:04 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-09-10 11:59:56 PDT
Currently, EditorClientQt::setInputMethodState emits microFocusChanged only when view is present.  For viewless client like wrt canvas, it also need to get this signal that some special actions can be triggered (like VKB in s60 5.0).
Comment 1 Yongjun Zhang 2009-09-10 12:04:43 PDT
Created attachment 39363 [details]
emit microFocusChanged() regardless of view.
Comment 2 Simon Hausmann 2009-09-11 00:09:49 PDT
Comment on attachment 39363 [details]
emit microFocusChanged() regardless of view.

r=me, thanks

This is a correct change, but I think it will need more work to fully function. This ties into the discussion about
making QWebPage work better in environments without a view but a graphics item instead. Just emitting the signal
helps, but it's not sufficient to determine then if the input method should be enabled or not.

Please see also the discussion in #28862 and the follow-up in #29085. We could benefit from your experience in using it without a view :)
Comment 3 WebKit Commit Bot 2009-09-11 01:55:57 PDT
Comment on attachment 39363 [details]
emit microFocusChanged() regardless of view.

Clearing flags on attachment: 39363

Committed r48291: <http://trac.webkit.org/changeset/48291>
Comment 4 WebKit Commit Bot 2009-09-11 01:56:03 PDT
All reviewed patches have been landed.  Closing bug.