Bug 291351 – `crossOrigin` should have CEReactions in `SVGImageElement` similar to other interfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Ahmad Saleem]

Hi Team,

Just noticed that our interface + spec does not have `CEReactions=NotNeeded` for crossOrigin in `SVGImageElement.idl`.

Source: https://github.com/WebKit/WebKit/blob/38743469d326c20ba7021c836915fca787e5c13c/Source/WebCore/svg/SVGImageElement.idl#L35

Web-Specification: https://svgwg.org/svg2-draft/embedded.html#InterfaceSVGImageElement

NOTE - `CEReactions=NotNeeded` is WebKit specific, in other browser, it is just `CEReactions` (also what it in specification), I think our implementation is different because of `is` attribute. (If incorrect, happy to be corrected).

__________

Now what we do in other interfaces:

Searchfox link - https://searchfox.org/wubkat/search?q=DOMString%3F+crossOrigin%3B&path=.idl&case=false&regexp=false

^ All of them have `CEReactions=NotNeeded`.

_______

Now other browsers:

** Chrome **

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/svg/svg_image_element.idl;l=38?q=svg_image_element.idl

^ have [CEReactions] for `crossOrigin`.

*** Firefox ***

https://searchfox.org/mozilla-central/rev/6cc05c6620814bf3eb05278ccf3b1f49690b7740/dom/webidl/SVGImageElement.webidl#26

^ Don't have [CEReactions] for `crossOrigin`.

____

Just raising so we can clarify from Anne or Ryosuke. Plus Karl in CC to clarify in SVGWG.

Thanks!

[Ryosuke Niwa]

We should add CEReactions=NotNeeded there. Because of the lack of is=, we don't need CEReactions.

[Radar WebKit Bug Importer]

<rdar://problem/148965117>

[Ahmad Saleem]

Pull request: https://github.com/WebKit/WebKit/pull/43886

[EWS]

Committed 293512@main (4934e4113790): <https://commits.webkit.org/293512@main>

Reviewed commits have been landed. Closing PR #43886 and removing active labels.