Bug 29119 - [GTK] EventSender does not properly convert some keyDown strings
Summary: [GTK] EventSender does not properly convert some keyDown strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-09 23:29 PDT by Martin Robinson
Modified: 2009-09-10 07:04 PDT (History)
1 user (show)

See Also:


Attachments
Patch for this issue (3.02 KB, patch)
2009-09-09 23:36 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2009-09-09 23:29:02 PDT
I'm working on getting some more of the key event unit tests passing in GTK+. I noticed that some keyDown strings used in the LayoutTests are not properly converted to GDK key codes in the GTK+ EventSender.
Comment 1 Martin Robinson 2009-09-09 23:36:53 PDT
Created attachment 39325 [details]
Patch for this issue

I've attached a small patch which adds more key code conversions for event sender. Key codes like '\x8' (and in general all those less than '\x20') are not converted properly by gdk_unicode_to_keyval.
Comment 2 Xan Lopez 2009-09-10 06:51:37 PDT
Comment on attachment 39325 [details]
Patch for this issue

r=me
Comment 3 WebKit Commit Bot 2009-09-10 07:04:40 PDT
Comment on attachment 39325 [details]
Patch for this issue

Clearing flags on attachment: 39325

Committed r48253: <http://trac.webkit.org/changeset/48253>
Comment 4 WebKit Commit Bot 2009-09-10 07:04:44 PDT
All reviewed patches have been landed.  Closing bug.