RESOLVED INVALID290911
filter-test-logs should signal failure when the scripts fail partway through 
https://bugs.webkit.org/show_bug.cgi?id=290911
Summary filter-test-logs should signal failure when the scripts fail partway through
Angelos Oikonomopoulos
Reported 2025-04-02 04:41:57 PDT
As it stands, when run-javascriptcore-tests or run-jsc-stress-tests throw an exception, filter-test-logs exits with 0 and doesn't report anything wrong. This results in a green bubble in buildbot.
Attachments
Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2025-04-02 04:44:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/43458
Angelos Oikonomopoulos
Comment 2 2025-04-02 04:47:30 PDT
Note, an additional fix, to make things more robust, would be to change the buildbot command to ensure that we don't discard the exit code from run-javascriptcore-tests.
Angelos Oikonomopoulos
Comment 3 2025-04-09 03:02:51 PDT
Closing as too brittle of a solution, see discussion in the PR.
Note You need to log in before you can comment on or make changes to this bug.