Bug 29091 - commit-queue hangs if a builder has never built
Summary: commit-queue hangs if a builder has never built
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-09 10:19 PDT by Eric Seidel (no email)
Modified: 2009-09-09 15:21 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (3.06 KB, patch)
2009-09-09 10:20 PDT, Eric Seidel (no email)
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-09-09 10:19:45 PDT
commit-queue hangs if a builder has never built

buildbot.py was throwing exceptions when trying to parse the buildbot page if one of the builders had never built.  Fixed.
Comment 1 Eric Seidel (no email) 2009-09-09 10:20:34 PDT
Created attachment 39276 [details]
Patch v1
Comment 2 David Levin 2009-09-09 11:36:37 PDT
Comment on attachment 39276 [details]
Patch v1

r=me if there is a good answer to my question below.

> diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py
> +        if not status_link:
> +            # We failed to find a link in the first cell, just give up.
> +            # This can happen if a builder is just-added, the first cell will just be "no build"
> +            return builder

Are other parts of the code robust to 'built_revision', 'is_green', 'build_url' not being in builder?

> diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py
> +      <td align="center" class="Activity building">building<br />< 1 min</td>

&lt; 1 min ?
Comment 3 Eric Seidel (no email) 2009-09-09 11:40:46 PDT
(In reply to comment #2)
> (From update of attachment 39276 [details])
> r=me if there is a good answer to my question below.
> 
> > diff --git a/WebKitTools/Scripts/modules/buildbot.py b/WebKitTools/Scripts/modules/buildbot.py
> > +        if not status_link:
> > +            # We failed to find a link in the first cell, just give up.
> > +            # This can happen if a builder is just-added, the first cell will just be "no build"
> > +            return builder
> 
> Are other parts of the code robust to 'built_revision', 'is_green', 'build_url'
> not being in builder?

Possibly not.  I'll check before landing and fix it to add is_green, etc if necessary.

> > diff --git a/WebKitTools/Scripts/modules/buildbot_unittest.py b/WebKitTools/Scripts/modules/buildbot_unittest.py
> > +      <td align="center" class="Activity building">building<br />< 1 min</td>
> 
> &lt; 1 min ?

I literally copy/pasted from the buildbot html source. :)  So I think I'll leave it as this "invalid" html for now. :)
Comment 4 Eric Seidel (no email) 2009-09-09 15:21:14 PDT
Committed r48230: <http://trac.webkit.org/changeset/48230>