Bug 29085 - Make PlatformWindow return something else than PlatformWidget
: Make PlatformWindow return something else than PlatformWidget
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: All All
: P2 Enhancement
Assigned To:
:
: Qt
:
:
  Show dependency treegraph
 
Reported: 2009-09-09 07:17 PST by
Modified: 2009-09-18 10:35 PST (History)


Attachments
Make PlatformWindow return something else than PlatformWidget (54.78 KB, patch)
2009-09-17 11:27 PST, Kenneth Rohde Christiansen
hausmann: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-09 07:17:38 PST
For the Qt port we would like to differentiate the return type of platformWidget and platformWindow, so that we can typedef that to something else.

In particular we would like to use platformWindow to return a QWebPageClient.

Since the platformWindow is per page, I would additionally like to rename it to platformChromeClient or platformPageClient. Any objections to such a change?
------- Comment #1 From 2009-09-09 07:59:59 PST -------
You should talk to Hyatt about this change. He added the PlatformWindow stuff, I believe.
------- Comment #2 From 2009-09-10 10:02:51 PST -------
Seems fine.
------- Comment #3 From 2009-09-17 11:27:48 PST -------
Created an attachment (id=39712) [details]
Make PlatformWindow return something else than PlatformWidget
------- Comment #4 From 2009-09-18 07:19:45 PST -------
(From update of attachment 39712 [details])
r=me
------- Comment #5 From 2009-09-18 07:20:34 PST -------
Eric, does this require any changes in Chromium? How can we synchronize the landing with the changes needed in Chromium?
------- Comment #6 From 2009-09-18 07:42:09 PST -------
Adding Darin (fishd).
------- Comment #7 From 2009-09-18 09:20:50 PST -------
This requires a small renaming change in the Chromium repository.  Fortunately, we always return NULL for the platformWidget.  So, the fixup on our end should just be about renaming the ChromeClient method.
------- Comment #8 From 2009-09-18 09:28:26 PST -------
(In reply to comment #7)
> This requires a small renaming change in the Chromium repository.  Fortunately,
> we always return NULL for the platformWidget.  So, the fixup on our end should
> just be about renaming the ChromeClient method.

That said, is it OK with you that I commit this right away?
------- Comment #9 From 2009-09-18 10:31:36 PST -------
We'll be able to cope.  Thanks!
------- Comment #10 From 2009-09-18 10:35:06 PST -------
Thansk! Landed in 48511