Bug 29083 – Disable some ARM compiler warnings

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

By default the ARM compiler is very chatty and it is hard to see "the wood for the trees".

I would propose to disable the following ARM warnings (as far as I can tell none of these warnings are enabled on most ports):

#68-D: integer conversion resulted in a change of sign
#111-D: statement is unreachable
#177-D: variable XXX was declared but never referenced
#368-D: class XXX defines no constructor to initialize the following: YYY
#830-D: function XXX "XXX::operator new" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object)
#1293-D: assignment in condition

[Laszlo Gombos]

Created attachment 39268 [details]
proposed path

Also did a bit of refactoring so that the rules don't repeat for all ARM compiler targets.

[Eric Seidel (no email)]

Maybe we should add a comment in the build file about the warnings you are disabling?  Or at least in the ChangeLog?

[Laszlo Gombos]

(In reply to comment #2)
> Maybe we should add a comment in the build file about the warnings you are
> disabling?  Or at least in the ChangeLog?

Eric, I will add the list of warnings to the ChangeLog when I commit. Thanks !

[Laszlo Gombos]

Created attachment 39272 [details]
Updated ChangeLog

Incorporating Eric's comment.

[Eric Seidel (no email)]

Do you really want to disable all these?

#68-D: integer conversion resulted in a change of sign
#111-D: statement is unreachable
#177-D: variable XXX was declared but never referenced
#368-D: class XXX defines no constructor to initialize the following: YYY
#830-D: function XXX "XXX::operator new" has no corresponding operator delete
(to be called if an exception is thrown during initialization of an allocated
object)
#1293-D: assignment in condition

All of those sound useful (and likely real bugs), no?

[Laszlo Gombos]

(In reply to comment #5)
> Do you really want to disable all these?
> 
> #68-D: integer conversion resulted in a change of sign
> #111-D: statement is unreachable
> #177-D: variable XXX was declared but never referenced
> #368-D: class XXX defines no constructor to initialize the following: YYY
> #830-D: function XXX "XXX::operator new" has no corresponding operator delete
> (to be called if an exception is thrown during initialization of an allocated
> object)
> #1293-D: assignment in condition
> 
> All of those sound useful (and likely real bugs), no?

Eric, I scanned trough the warnings and the corresponding code and I could not spot a real bug. The direction is definitively to get rid of all the warnings gradually (and take them out from this list), but restricting the list help to focus on the remaining warnings first.

[Laszlo Gombos]

Committed as http://trac.webkit.org/changeset/48250