Bug 29083 - Disable some ARM compiler warnings
Summary: Disable some ARM compiler warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-09 06:54 PDT by Laszlo Gombos
Modified: 2009-09-10 05:01 PDT (History)
1 user (show)

See Also:


Attachments
proposed path (1.37 KB, patch)
2009-09-09 07:06 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff
Updated ChangeLog (1.81 KB, patch)
2009-09-09 09:29 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-09-09 06:54:29 PDT
By default the ARM compiler is very chatty and it is hard to see "the wood for the trees".

I would propose to disable the following ARM warnings (as far as I can tell none of these warnings are enabled on most ports):

#68-D: integer conversion resulted in a change of sign
#111-D: statement is unreachable
#177-D: variable XXX was declared but never referenced
#368-D: class XXX defines no constructor to initialize the following: YYY
#830-D: function XXX "XXX::operator new" has no corresponding operator delete (to be called if an exception is thrown during initialization of an allocated object)
#1293-D: assignment in condition
Comment 1 Laszlo Gombos 2009-09-09 07:06:52 PDT
Created attachment 39268 [details]
proposed path

Also did a bit of refactoring so that the rules don't repeat for all ARM compiler targets.
Comment 2 Eric Seidel (no email) 2009-09-09 07:53:19 PDT
Maybe we should add a comment in the build file about the warnings you are disabling?  Or at least in the ChangeLog?
Comment 3 Laszlo Gombos 2009-09-09 08:01:34 PDT
(In reply to comment #2)
> Maybe we should add a comment in the build file about the warnings you are
> disabling?  Or at least in the ChangeLog?

Eric, I will add the list of warnings to the ChangeLog when I commit. Thanks !
Comment 4 Laszlo Gombos 2009-09-09 09:29:14 PDT
Created attachment 39272 [details]
Updated ChangeLog

Incorporating Eric's comment.
Comment 5 Eric Seidel (no email) 2009-09-09 16:52:31 PDT
Do you really want to disable all these?

#68-D: integer conversion resulted in a change of sign
#111-D: statement is unreachable
#177-D: variable XXX was declared but never referenced
#368-D: class XXX defines no constructor to initialize the following: YYY
#830-D: function XXX "XXX::operator new" has no corresponding operator delete
(to be called if an exception is thrown during initialization of an allocated
object)
#1293-D: assignment in condition

All of those sound useful (and likely real bugs), no?
Comment 6 Laszlo Gombos 2009-09-10 04:48:52 PDT
(In reply to comment #5)
> Do you really want to disable all these?
> 
> #68-D: integer conversion resulted in a change of sign
> #111-D: statement is unreachable
> #177-D: variable XXX was declared but never referenced
> #368-D: class XXX defines no constructor to initialize the following: YYY
> #830-D: function XXX "XXX::operator new" has no corresponding operator delete
> (to be called if an exception is thrown during initialization of an allocated
> object)
> #1293-D: assignment in condition
> 
> All of those sound useful (and likely real bugs), no?

Eric, I scanned trough the warnings and the corresponding code and I could not spot a real bug. The direction is definitively to get rid of all the warnings gradually (and take them out from this list), but restricting the list help to focus on the remaining warnings first.
Comment 7 Laszlo Gombos 2009-09-10 05:01:34 PDT
Committed as http://trac.webkit.org/changeset/48250