Bug 29048 - [Qt] make RenderStyle.h compile in winscw compiler.
: [Qt] make RenderStyle.h compile in winscw compiler.
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: S60 Emulator S60 3rd edition
: P2 Normal
Assigned To:
:
: Qt
:
: 27065
  Show dependency treegraph
 
Reported: 2009-09-08 13:43 PST by
Modified: 2010-12-16 09:28 PST (History)


Attachments
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template. (1.25 KB, patch)
2009-09-08 14:50 PST, Yongjun Zhang
eric: review-
Review Patch | Details | Formatted Diff | Diff
add link to winscw compiler bug as suggested by Erik. (1.34 KB, patch)
2009-12-30 14:27 PST, Yongjun Zhang
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-08 13:43:27 PST
In RenderStyle.h, Winscw compiler is not able to resolve compareEuqal used in SET_VAR macro; the compiler reports error "illegal operand".
------- Comment #1 From 2009-09-08 14:50:49 PST -------
Created an attachment (id=39217) [details]
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.
------- Comment #2 From 2009-09-08 14:53:39 PST -------
(From update of attachment 39217 [details])
There needs to be a comment next to the macro definition as to why it exists.

Also, could you paste the error in the bug?  Are we sure this is the best solution?  Do we have a bug filed with the winscw compiler?  If so, can we link to it?
------- Comment #3 From 2009-09-09 02:55:53 PST -------
Please use the keyword 'Qt' for bugs related to QtWebKit. The component 'WebKit Qt' is for QtWebKit API issues only.
------- Comment #4 From 2009-12-29 03:45:58 PST -------
This appears to be one of the few remaining WINSCW issues. Any update on this about the error message, etc.? (See Eric's comment)
------- Comment #5 From 2009-12-30 14:25:56 PST -------
There was a bug reported against this in Winscw compiler bugzilla:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447
------- Comment #6 From 2009-12-30 14:27:21 PST -------
Created an attachment (id=45686) [details]
add link to winscw compiler bug as suggested by Erik.
------- Comment #7 From 2009-12-30 14:33:53 PST -------
style-queue ran check-webkit-style on attachment 45686 [details] without any errors.
------- Comment #8 From 2009-12-31 07:03:38 PST -------
(From update of attachment 45686 [details])
Looks good to me, r+; 

At commit, it would be useful to add a comment right by the macro in RenderStyle.h as well, as Eric suggested.
------- Comment #9 From 2010-01-04 07:33:50 PST -------
(From update of attachment 45686 [details])
Clearing flags on attachment: 45686

Committed r52733: <http://trac.webkit.org/changeset/52733>
------- Comment #10 From 2010-01-04 07:33:55 PST -------
All reviewed patches have been landed.  Closing bug.