Bug 29048 – [Qt] make RenderStyle.h compile in winscw compiler.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Yongjun Zhang]

In RenderStyle.h, Winscw compiler is not able to resolve compareEuqal used in SET_VAR macro; the compiler reports error "illegal operand".

[Yongjun Zhang]

Created attachment 39217 [details]
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.

[Eric Seidel (no email)]

Comment on attachment 39217 [details]
Change compareEqual to a macro in Winscw compiler to get around "illegal operand" error when compareEqual is defined as template.

There needs to be a comment next to the macro definition as to why it exists.

Also, could you paste the error in the bug?  Are we sure this is the best solution?  Do we have a bug filed with the winscw compiler?  If so, can we link to it?

[Tor Arne Vestbø]

Please use the keyword 'Qt' for bugs related to QtWebKit. The component 'WebKit Qt' is for QtWebKit API issues only.

[Simon Hausmann]

This appears to be one of the few remaining WINSCW issues. Any update on this about the error message, etc.? (See Eric's comment)

[Yongjun Zhang]

There was a bug reported against this in Winscw compiler bugzilla:
https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=10447

[Yongjun Zhang]

Created attachment 45686 [details]
add link to winscw compiler bug as suggested by Erik.

[WebKit Review Bot]

style-queue ran check-webkit-style on attachment 45686 [details] without any errors.

[Laszlo Gombos]

Comment on attachment 45686 [details]
add link to winscw compiler bug as suggested by Erik.

Looks good to me, r+; 

At commit, it would be useful to add a comment right by the macro in RenderStyle.h as well, as Eric suggested.

[WebKit Commit Bot]

Comment on attachment 45686 [details]
add link to winscw compiler bug as suggested by Erik.

Clearing flags on attachment: 45686

Committed r52733: <http://trac.webkit.org/changeset/52733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.