Bug 29043 - shared-worker-exception.html needs to pause to let console messages get written out
Summary: shared-worker-exception.html needs to pause to let console messages get writt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Andrew Wilson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-08 11:46 PDT by Andrew Wilson
Modified: 2009-09-08 18:46 PDT (History)
0 users

See Also:

Attachments
proposed patch (1.25 KB, patch)
2009-09-08 17:28 PDT, Andrew Wilson 		mjs: review+
mjs: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Wilson 2009-09-08 11:46:18 PDT 
The test is slightly flaky because sometimes the console message doesn't get written out until the subsequent test runs, leading to two broken tests.
Comment 1 Andrew Wilson 2009-09-08 17:28:18 PDT 
Created attachment 39234 [details]
proposed patch

Updated layout test to pause 10ms before shutting down the test to let unhandled worker exceptions get written to the console.
Comment 2 Maciej Stachowiak 2009-09-08 18:18:06 PDT 
Comment on attachment 39234 [details]
proposed patch

r=me

Try using a 0-delay timer - from IRC discussion, I believe it will achieve the desired goal here.
Comment 3 Andrew Wilson 2009-09-08 18:46:03 PDT 
Committed as r48196 (with 0-msec timer)