Bug 29032 – [Qt] locale date displays incorrect date format in symbian

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Pat]

Using the javascript code below displays incorrectly in symbian:

var d = new Date();
document.write("toLocaleDateString: " + d.toLocaleDateString());

Should display: toLocaleDateString: Tuesday, September 8, 2009
Actual display #x

A fix would follow shortly.

[Pat]

Created attachment 39185 [details]
Patch

[Tor Arne Vestbø]

Please use the keyword 'Qt' for bugs related to QtWebKit.

[Eric Seidel (no email)]

Comment on attachment 39185 [details]
Patch

Is this covered by an existing layout test?  If so, please update the ChangeLog to say so.  Otherwise we need to write a new test.

Also, it seems we should update the comment:
     // strftime() we are using does not support #
To say something like:
     // strftime() does not support '#' on WinCE or Symbian.

[Pat]

Created attachment 39201 [details]
updated patch

Updated the comment to reflect that strftime() does not support '#' on both WinCE and Symbian.

We are not able to run layout tests on Symbian yet, so layout tests are not affected.

[Eric Seidel (no email)]

Comment on attachment 39201 [details]
updated patch

Rejecting patch 39201 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

[Yael]

(In reply to comment #5)
> (From update of attachment 39201 [details])
> Rejecting patch 39201 from commit-queue.
> 
> [e-mail] does not have committer permissions according to
> http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py.

Eric, I added myself today to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. I hope you don't mind to set the flag back :-)

[Eric Seidel (no email)]

Comment on attachment 39201 [details]
updated patch

Rejecting patch 39201 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1

[Yael]

Landed in 48205

[Eric Seidel (no email)]

storage/database-lock-after-reload.html -> failed

Possibly just a flakey test?