RESOLVED FIXED 29027
Geolocation requires method to set permission for testing with mock service
https://bugs.webkit.org/show_bug.cgi?id=29027
Summary Geolocation requires method to set permission for testing with mock service
Steve Block
Reported 2009-09-08 02:19:38 PDT
Geolocation is tested in the LayoutTests using a mock implementation of the Geolocation service. See Bug 28246. A test currently exists to test the failure case. See LayoutTests/fast/dom/Geolocation/error.html. In order to test the success case, and cases where the user denies permission, we need to be able to set Geolocation permission from the LayoutTests.
Attachments
Patch 1 for bug 29027 (13.51 KB, patch)
2009-09-08 03:47 PDT, Steve Block
no flags
Steve Block
Comment 1 2009-09-08 02:20:50 PDT
This blocks other Geolocation bugs that require testing.
Steve Block
Comment 2 2009-09-08 03:47:38 PDT
Created attachment 39179 [details] Patch 1 for bug 29027 Implements a method to set the Geolocation permission state on Mac and adds corresponding tests.
Adam Barth
Comment 3 2009-09-08 07:48:41 PDT
Comment on attachment 39179 [details] Patch 1 for bug 29027 Seems like we might eventually need a per-origin version of this API to test the permission system in more detail, but this seems fine for now to unblock improvements to Geolocation. Thanks.
Eric Seidel (no email)
Comment 4 2009-09-08 08:43:39 PDT
Comment on attachment 39179 [details] Patch 1 for bug 29027 Clearing flags on attachment: 39179 Committed r48156: <http://trac.webkit.org/changeset/48156>
Eric Seidel (no email)
Comment 5 2009-09-08 08:43:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.