Bug 29027 - Geolocation requires method to set permission for testing with mock service
Summary: Geolocation requires method to set permission for testing with mock service
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27255 27256 27944
  Show dependency treegraph
 
Reported: 2009-09-08 02:19 PDT by Steve Block
Modified: 2009-09-08 08:43 PDT (History)
4 users (show)

See Also:


Attachments
Patch 1 for bug 29027 (13.51 KB, patch)
2009-09-08 03:47 PDT, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-09-08 02:19:38 PDT
Geolocation is tested in the LayoutTests using a mock implementation of the Geolocation service. See Bug 28246.

A test currently exists to test the failure case. See LayoutTests/fast/dom/Geolocation/error.html. In order to test the success case, and cases where the user denies permission, we need to be able to set Geolocation permission from the LayoutTests.
Comment 1 Steve Block 2009-09-08 02:20:50 PDT
This blocks other Geolocation bugs that require testing.
Comment 2 Steve Block 2009-09-08 03:47:38 PDT
Created attachment 39179 [details]
Patch 1 for bug 29027

Implements a method to set the Geolocation permission state on Mac and adds corresponding tests.
Comment 3 Adam Barth 2009-09-08 07:48:41 PDT
Comment on attachment 39179 [details]
Patch 1 for bug 29027

Seems like we might eventually need a per-origin version of this API to test the permission system in more detail, but this seems fine for now to unblock improvements to Geolocation.  Thanks.
Comment 4 Eric Seidel (no email) 2009-09-08 08:43:39 PDT
Comment on attachment 39179 [details]
Patch 1 for bug 29027

Clearing flags on attachment: 39179

Committed r48156: <http://trac.webkit.org/changeset/48156>
Comment 5 Eric Seidel (no email) 2009-09-08 08:43:44 PDT
All reviewed patches have been landed.  Closing bug.