WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
290216
[GTK][WPE][Skia] Stop using finishAcceleratedRenderingAndCreateFence & friends in ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=290216
Summary
[GTK][WPE][Skia] Stop using finishAcceleratedRenderingAndCreateFence & friend...
Nikolas Zimmermann
Reported
2025-03-21 14:38:08 PDT
ImageBuffer::sinkIntoImageBufferForCrossThreadTransfer() and ImageBuffer::sinkIntoImageBufferAfterCrossThreadTransfer() make use of finishAcceleratedRenderingAndCreateFence / waitForAcceleratedRenderingFenceCompletion / copyAcceleratedImageBufferBorrowingBackendRenderTarget. These functions and the Skia-specific DisplayList code still use these methods. After switching from using DisplayList to SkPicture in SkiaPaintingEngine, we can purge the whole fencing logic from ImageBuffer/NativeImage & friends.
Attachments
Add attachment
proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1
2025-03-21 14:48:44 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/42843
EWS
Comment 2
2025-03-26 06:37:41 PDT
Committed
292699@main
(f18fd5a7e638): <
https://commits.webkit.org/292699@main
> Reviewed commits have been landed. Closing PR #42843 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug