The significance of this work is to make a step towards enforcing the same code quality measures as other WebKit ports (most notably the mac port) so that contributors focusing on a specific WebKit ports are less likely break other ports because of the difference in quality requirements. List of gcc warnings (with elevated warning level) - these warnings are not present in the port independent WebKit code: WebCore/history/qt/HistoryItemQt.cpp:48: warning: unused variable 'loadFormdata' WebCore/platform/graphics/qt/ImageBufferQt.cpp:241: warning: unused variable 'basex' WebCore/platform/qt/RenderThemeQt.cpp:575: warning: unused variable 'appearance' WebKit/qt/Api/qwebpage.cpp:829: warning: unused variable 'fontHeight' WebKit/qt/Api/qwebpage.cpp:817: warning: unused variable 'editor' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:959: warning: unused variable 'page' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:989: warning: unused variable 'loadType' WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:990: warning: unused variable 'childLoadType'
Created attachment 39161 [details] proposed patch. Removed dead code except in WebCore/history/qt/HistoryItemQt.cpp, where it made more sense to comment it out.
Comment on attachment 39161 [details] proposed patch. r=me
Comment on attachment 39161 [details] proposed patch. Clearing flags on attachment: 39161 Committed r48165: <http://trac.webkit.org/changeset/48165>
All reviewed patches have been landed. Closing bug.