Bug 29017 – [Qt] Use the declaration order in initializer lists

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

Class members are initialised in the order they are declared, not the order they appear in initialiser lists. It is a good practice to put the elements of the member initialization list in the same order as the data members of the class. This practice seems to be followed WebKit, let's bring this to QtWebKit port as well.

This is sometimes reported as a compiler warning for some compilers (e.g. gcc with high enough warning level).

[Laszlo Gombos]

Created attachment 39160 [details]
proposed patch

[Laszlo Gombos]

gcc warning (with elevated warning level) for reference:

WebCore/platform/graphics/qt/FontCacheQt.cpp: In constructor 'WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey(const WebCore::FontDescription&)':
WebCore/platform/graphics/qt/FontCacheQt.cpp:136: warning: 'WebCore::FontPlatformDataCacheKey::m_bold' will be initialized after
WebCore/platform/graphics/qt/FontCacheQt.cpp:135: warning:   'int WebCore::FontPlatformDataCacheKey::m_size'
WebCore/platform/graphics/qt/FontCacheQt.cpp:59: warning:   when initialized here

WebKit/qt/Api/qwebframe_p.h: In constructor 'QWebFramePrivate::QWebFramePrivate()':
WebKit/qt/Api/qwebframe_p.h:90: warning: 'QWebFramePrivate::q' will be initialized after
WebKit/qt/Api/qwebframe_p.h:82: warning:   'Qt::ScrollBarPolicy QWebFramePrivate::horizontalScrollBarPolicy'
WebKit/qt/Api/qwebframe_p.h:63: warning:   when initialized here

WebCore/platform/network/qt/QNetworkReplyHandler.h: In constructor 'WebCore::QNetworkReplyHandler::QNetworkReplyHandler(WebCore::ResourceHandle*, WebCore::QNetworkR
eplyHandler::LoadMode)':
WebCore/platform/network/qt/QNetworkReplyHandler.h:73: warning: 'WebCore::QNetworkReplyHandler::m_resourceHandle' will be initialized after
WebCore/platform/network/qt/QNetworkReplyHandler.h:72: warning:   'QNetworkReply* WebCore::QNetworkReplyHandler::m_reply'
WebCore/platform/network/qt/QNetworkReplyHandler.cpp:132: warning:   when initialized here

[Eric Seidel (no email)]

Comment on attachment 39160 [details]
proposed patch

Clearing flags on attachment: 39160

Committed r48164: <http://trac.webkit.org/changeset/48164>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.