WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
290114
Minor cleanups identified during review of ComplexTextController
https://bugs.webkit.org/show_bug.cgi?id=290114
Summary
Minor cleanups identified during review of ComplexTextController
Brent Fulgham
Reported
2025-03-20 12:17:48 PDT
The code for `ComplexTextController::adjustGlyphsAndAdvances()` has multiple conditionals that never change during the text run, and could be avoided by making the method a template that would remove unneeded conditionals.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-03-20 12:18:10 PDT
<
rdar://problem/147517437
>
Brent Fulgham
Comment 2
2025-03-20 12:29:51 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/42756
EWS
Comment 3
2025-04-02 16:05:58 PDT
Committed
293130@main
(fe228e0d18f6): <
https://commits.webkit.org/293130@main
> Reviewed commits have been landed. Closing PR #42756 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug