Bug 29011 - Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
: Build fix when USE(LOCKFREE_THREADSAFESHARED) is not defined
Status: RESOLVED FIXED
: WebKit
Platform
: 528+ (Nightly build)
: PC Other
: P2 Normal
Assigned To:
:
:
:
: 27065
  Show dependency treegraph
 
Reported: 2009-09-07 08:11 PST by
Modified: 2009-10-01 09:35 PST (History)


Attachments
proposed patch. (1.11 KB, patch)
2009-09-07 08:17 PST, Laszlo Gombos
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-07 08:11:18 PST
Some WebKit ports (e.g. Symbian QtWebKit port) does not (yet) define atomicIncrement and atomicDecrement functions. This is a "supported" configuration and the USE(LOCKFREE_THREADSAFESHARED) is used to determine if atomicIncrement and atomicDecrement functions are available.

ChangeSet http://trac.webkit.org/changeset/47845 introduced a change in Threading.h which would require to implement atomicIncrement and atomicDecrement functions for all ports. Guarding some of the changes in Threading.h with USE(LOCKFREE_THREADSAFESHARED) would fix this problem (and would fix the Symbian QtWebKit build). Patch will follow.
------- Comment #1 From 2009-09-07 08:17:40 PST -------
Created an attachment (id=39148) [details]
proposed patch.
------- Comment #2 From 2009-09-07 09:40:17 PST -------
(From update of attachment 39148 [details])
r=me
------- Comment #3 From 2009-09-08 03:29:04 PST -------
*** Bug 29028 has been marked as a duplicate of this bug. ***
------- Comment #4 From 2009-09-08 08:23:45 PST -------
(From update of attachment 39148 [details])
Exception: Unknown committer: laszlo.1.gombos@nokia.com

If you're a committer, please make sure you're in LayoutTests/WebKitTools/Scripts/modules/committers.py
------- Comment #5 From 2009-09-08 09:14:16 PST -------
(From update of attachment 39148 [details])
Thanks Eric !

Added myself to list of committers -- http://trac.webkit.org/changeset/48159.

Let's try the commit-queue again.
------- Comment #6 From 2009-09-08 10:15:09 PST -------
(From update of attachment 39148 [details])
Clearing flags on attachment: 39148

Committed r48161: <http://trac.webkit.org/changeset/48161>
------- Comment #7 From 2009-09-08 10:15:15 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #8 From 2009-09-10 15:29:01 PST -------
*** Bug 29149 has been marked as a duplicate of this bug. ***