Bug 29009 - [V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
Summary: [V8] Cleanup document/frame null-checking in V8DOMWindowCustom.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-07 07:01 PDT by Mads Ager
Modified: 2009-09-07 07:49 PDT (History)
2 users (show)

See Also:


Attachments
Be consistent in document and frame null checking. (5.49 KB, patch)
2009-09-07 07:24 PDT, Mads Ager
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2009-09-07 07:01:08 PDT
The document and frame null checking in V8DOMWindowCustom.cpp is inconsistent and a couple of checks are missing.

We should use the DOMWindow::document accessor and let that one null check the frame.  We should always null check the result of that accessor.  canAccessFrame returns false for a null frame - we should use that fact consistently.
Comment 1 Mads Ager 2009-09-07 07:24:24 PDT
Created attachment 39145 [details]
Be consistent in document and frame null checking.
Comment 2 Eric Seidel (no email) 2009-09-07 07:49:12 PDT
Comment on attachment 39145 [details]
Be consistent in document and frame null checking.

Clearing flags on attachment: 39145

Committed r48114: <http://trac.webkit.org/changeset/48114>
Comment 3 Eric Seidel (no email) 2009-09-07 07:49:16 PDT
All reviewed patches have been landed.  Closing bug.