RESOLVED FIXED 29007
There is no test for the signal javaScriptWindowObjectCleared() 
https://bugs.webkit.org/show_bug.cgi?id=29007
Summary There is no test for the signal javaScriptWindowObjectCleared()
Benjamin Poulain
Reported 2009-09-07 04:25:19 PDT
There is no test case for the signal javaScriptWindowObjectCleared() of QWebFrame, it would be nice to have one.
Attachments
New test for the signal (2.41 KB, patch)
2009-09-07 04:27 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2009-09-07 04:27:11 PDT
Created attachment 39141 [details] New test for the signal
Simon Hausmann
Comment 2 2009-09-07 05:52:51 PDT
Comment on attachment 39141 [details] New test for the signal r=me, thanks Benjamin!
Eric Seidel (no email)
Comment 3 2009-09-07 07:08:19 PDT
Comment on attachment 39141 [details] New test for the signal Rejecting patch 39141 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Eric Seidel (no email)
Comment 4 2009-09-08 10:13:49 PDT
Comment on attachment 39141 [details] New test for the signal media/video-seeking.html -> failed Another flakey media test. :(
Eric Seidel (no email)
Comment 5 2009-09-08 10:44:25 PDT
Comment on attachment 39141 [details] New test for the signal Clearing flags on attachment: 39141 Committed r48166: <http://trac.webkit.org/changeset/48166>
Eric Seidel (no email)
Comment 6 2009-09-08 10:44:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.