RESOLVED FIXED29006
WebInspector: Make m_windowVisible more consistent with the actual visibility of the inspector. 
https://bugs.webkit.org/show_bug.cgi?id=29006
Summary WebInspector: Make m_windowVisible more consistent with the actual visibility...
Jocelyn Turcotte
Reported 2009-09-07 03:59:49 PDT
Created attachment 39139 [details] Suggested patch We faced a bug that calling: page->inspectorController()->show() page->inspectorController()->inspect(...) would not initialize the web inspector correctly. The call to inspect() will also call InspectorController::show() which will eventually call setWindowVisible() before the JS frontend has been initialized and prevent the real call to do its initialization in setWindowVisible() afterward. This patch prevent the m_windowVisible flag to be modified if m_frontend has not been initialized yet. Adding a bool parameter showInspector to InspectorController::inspect() with a default value of true would also correct this one problem.
Attachments
Suggested patch (1.14 KB, patch)
2009-09-07 03:59 PDT, Jocelyn Turcotte 		timothy: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2009-09-07 07:56:03 PDT
Comment on attachment 39139 [details] Suggested patch Rejecting patch 39139 from commit-queue. This patch will require manual commit. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html
Simon Hausmann
Comment 2 2009-09-08 00:45:31 PDT
Landed manually in r48146
Note You need to log in before you can comment on or make changes to this bug.