Bug 29003 - Detect mixed content
Summary: Detect mixed content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-06 21:14 PDT by Adam Barth
Modified: 2009-09-11 16:55 PDT (History)
8 users (show)

See Also:


Attachments
mixed-content patch (49.20 KB, patch)
2009-09-06 21:15 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
mixed-content patch (48.89 KB, patch)
2009-09-06 21:20 PDT, Adam Barth
sam: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-09-06 21:14:26 PDT
Now that we have the client callbacks, we should actually detect some mixed content (HTTP content loading into an HTTPS frame)!  In this bug, my plan is to just get some basic detection in the tree.  We can make sure we get all the corner cases right in follow-up bugs.
Comment 1 Adam Barth 2009-09-06 21:15:57 PDT
Created attachment 39131 [details]
mixed-content patch


---
 48 files changed, 708 insertions(+), 1 deletions(-)
Comment 2 Adam Barth 2009-09-06 21:20:02 PDT
Created attachment 39132 [details]
mixed-content patch


---
 48 files changed, 707 insertions(+), 1 deletions(-)
Comment 3 Sam Weinig 2009-09-10 21:11:15 PDT
Comment on attachment 39132 [details]
mixed-content patch

Looks great. r=me
Comment 4 Adam Barth 2009-09-10 21:57:54 PDT
Comment on attachment 39132 [details]
mixed-content patch

Rejecting patch 39132 from commit-queue.

This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--exit-after-n-failures=1'] failed with exit code 1
Comment 5 Adam Barth 2009-09-10 22:48:16 PDT
Committed r48284: <http://trac.webkit.org/changeset/48284>
Comment 6 Brian Weinstein 2009-09-11 14:55:38 PDT
These tests are failing on Windows, any idea what is going on?
Comment 7 Adam Barth 2009-09-11 15:06:45 PDT
Thanks for letting me know.  I'll investigate when I get home.
Comment 8 Brian Weinstein 2009-09-11 16:55:26 PDT
https://bugs.webkit.org/show_bug.cgi?id=29213 is tracking the test failures on Windows.