Functionality behind r47425 (http://trac.webkit.org/changeset/47425) is guarded with Qt v4.6 build check. Typically we do not use a build time Qt version check for newly introduced QtWebKit functionality. The usage of Qt version check is should be restricted to guard QtWebKit functionality that depends on a Qt functionality that is not available in all Qt versions. In this particular case the functionality introduced by r47425 builds and functions just fine using Qt v4.5. In addition removing the build flag also gets rid of a build warning (from moc).
Created attachment 39104 [details] proposed patch.
Comment on attachment 39104 [details] proposed patch. OK. rs=me. I can't remember if you're a committer. Assuming not. cq+
Comment on attachment 39104 [details] proposed patch. Rejecting patch 39104 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
(In reply to comment #3) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Eric, I can/will commit, thanks for the review.
Comment on attachment 39104 [details] proposed patch. Another victim of bug 28845. media/video-source-error.html -> timed out
(In reply to comment #6) > (From update of attachment 39104 [details]) > Rejecting patch 39104 from commit-queue. This patch will require manual > commit. > > ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', > '--exit-after-n-failures=1'] failed with exit code 1 Committed - http://trac.webkit.org/changeset/48100
Thank you. The commit-queue is kinda paralyzed by bug 28845 at the moment. This hit it *again* when trying to land.
Actually it hit a different test the final time, same bug though: compositing/geometry/abs-position-inside-opacity.html -> timed out