Bug 28991 – Drop <definition-src> support

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Cameron McCormack (:heycam)]

The partially implemented and underspecified <definition-src> SVG element can be dropped, since it has been removed from SVG 1.1 Second Edition:

  http://dev.w3.org/SVG/profiles/1.1F2/publish/changes.html#FontsChapter

[Cameron McCormack (:heycam)]

Created attachment 39103 [details]
Patch v1

Changes to build systems apart from the one that gets invoked when I run build-webkit are completely untested.  In particular, I'd be worried about the changes to the vcproj and pbxproj files, which were edited by eye.

[Eric Seidel (no email)]

Comment on attachment 39103 [details]
Patch v1

I was so excited by this change, and then it looks like you snuck in a functional change!
0     for (Node* child = firstChild(); child && !srcElement; child = child->nextSibling()) {
 281         if (child->hasTagName(font_face_srcTag))

Before we would use the last source it seems, and now we use the first!  If you're gonna do that, we need a test.

The rest of the change looked fine.  Glad to see this go!

[Cameron McCormack (:heycam)]

(In reply to comment #2)
> I was so excited by this change, and then it looks like you snuck in a
> functional change!
> 0     for (Node* child = firstChild(); child && !srcElement; child =
> child->nextSibling()) {
>  281         if (child->hasTagName(font_face_srcTag))
> 
> Before we would use the last source it seems, and now we use the first!  If
> you're gonna do that, we need a test.
> 
> The rest of the change looked fine.  Glad to see this go!

I think currently we use the first source too, since there's a "&& !srcElement" clause in the if statement, no?

[Eric Seidel (no email)]

Comment on attachment 39103 [details]
Patch v1

Yes, sorry.  You are correct.

[Eric Seidel (no email)]

Comment on attachment 39103 [details]
Patch v1

Clearing flags on attachment: 39103

Committed r48099: <http://trac.webkit.org/changeset/48099>

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.