Bug 28984 - Eliminate the remote user stylesheet loader on Mac/Qt
Summary: Eliminate the remote user stylesheet loader on Mac/Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-04 13:59 PDT by Dave Hyatt
Modified: 2009-09-09 04:49 PDT (History)
1 user (show)

See Also:


Attachments
Patch (20.49 KB, patch)
2009-09-04 14:01 PDT, Dave Hyatt
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2009-09-04 13:59:41 PDT
Remove the separate code path on Mac/Qt for user stylesheet loading.  Make sure the cross-platform code path used by everyone else gets data URL support to match Mac/Qt, and then switch everyone over to it.
Comment 1 Dave Hyatt 2009-09-04 14:01:15 PDT
Created attachment 39088 [details]
Patch
Comment 2 Adam Roben (:aroben) 2009-09-04 14:04:24 PDT
Comment on attachment 39088 [details]
Patch

>  void Page::userStyleSheetLocationChanged()
>  {
> -#if !FRAME_LOADS_USER_STYLESHEET
>      // FIXME: We should provide a way to load other types of URLs than just
> -    // file: (e.g., http:, data:).
> -    if (m_settings->userStyleSheetLocation().isLocalFile())
> -        m_userStyleSheetPath = m_settings->userStyleSheetLocation().fileSystemPath();
> +    // file: (e.g., http:).

I guess you don't agree with this FIXME at all. Maybe you should remove it?

You should remove UserStyleSheetLoader from the Qt project files.

You should explain in your ChangeLog how you made the decision that it's OK to do this.

Do we have regression tests for the user stylesheet code?

r=me
Comment 3 Dave Hyatt 2009-09-04 14:33:35 PDT
Fixed in r48075.