Bug 28981 - [Qt] make npapi.h compile in winscw compiler.
Summary: [Qt] make npapi.h compile in winscw compiler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Emulator S60 3rd edition
: P2 Minor
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-09-04 12:18 PDT by Yongjun Zhang
Modified: 2009-09-08 12:21 PDT (History)
2 users (show)

See Also:


Attachments
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian. (1.20 KB, patch)
2009-09-04 12:25 PDT, Yongjun Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-09-04 12:18:06 PDT
Winscw compiler by default defines _WIN32 macro; in npapi.h, this macro assumes the target environment is Windows and it tries to include <windows.h> and other windows specific code into Symbian build, the compilation as a result fails.
Comment 1 Yongjun Zhang 2009-09-04 12:25:33 PDT
Created attachment 39084 [details]
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian.
Comment 2 Eric Seidel (no email) 2009-09-08 11:12:57 PDT
Comment on attachment 39084 [details]
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian.

Rejecting patch 39084 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 3 Eric Seidel (no email) 2009-09-08 12:11:07 PDT
Comment on attachment 39084 [details]
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian.

media/video-source-error.html -> timed out

Yet another flakey media test. :(  bug 28624
Comment 4 Eric Seidel (no email) 2009-09-08 12:21:21 PDT
Comment on attachment 39084 [details]
Add XP_SYMBIAN macro for symbian build, and undef XP_WIN when building for Symbian.

Clearing flags on attachment: 39084

Committed r48174: <http://trac.webkit.org/changeset/48174>
Comment 5 Eric Seidel (no email) 2009-09-08 12:21:25 PDT
All reviewed patches have been landed.  Closing bug.