Bug 28966 - [HTML5][Forms] <input type=color> simple implementation
: [HTML5][Forms] <input type=color> simple implementation
Status: RESOLVED FIXED
: WebKit
Forms
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
: http://www.whatwg.org/specs/web-apps/...
:
:
: 19264 29358
  Show dependency treegraph
 
Reported: 2009-09-04 00:52 PST by
Modified: 2009-09-17 21:00 PST (History)


Attachments
Proposed patch (16.63 KB, patch)
2009-09-04 01:00 PST, Kent Tamura
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-04 00:52:19 PST
Implement type=color as a text field without a fancy color picker, and validation support for type=color.
------- Comment #1 From 2009-09-04 01:00:18 PST -------
Created an attachment (id=39044) [details]
Proposed patch
------- Comment #2 From 2009-09-04 01:21:50 PST -------
(From update of attachment 39044 [details])
I guess this is an OK start.  On Mac we'll want to use the NSColorWell I figure.  I don't see why it's useful to ever have a text box for color picking.
------- Comment #3 From 2009-09-04 01:32:58 PST -------
(From update of attachment 39044 [details])
Clearing flags on attachment: 39044

Committed r48043: <http://trac.webkit.org/changeset/48043>
------- Comment #4 From 2009-09-04 01:33:02 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #5 From 2009-09-04 02:11:17 PST -------
(In reply to comment #2)
> (From update of attachment 39044 [details] [details])
> I guess this is an OK start.  On Mac we'll want to use the NSColorWell I
> figure.  I don't see why it's useful to ever have a text box for color picking.

Definitely.  We'll work on the UI.
Thank you very much for the quick review.