Bug 28966 - [HTML5][Forms] <input type=color> simple implementation
: [HTML5][Forms] <input type=color> simple implementation
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Forms
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Nobody
http://www.whatwg.org/specs/web-apps/...
:
Depends on:
Blocks: HTML5Forms 29358
  Show dependency treegraph
 
Reported: 2009-09-04 00:52 PDT by Kent Tamura
Modified: 2009-09-17 21:00 PDT (History)
6 users (show)

See Also:


Attachments
Proposed patch (16.63 KB, patch)
2009-09-04 01:00 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2009-09-04 00:52:19 PDT
Implement type=color as a text field without a fancy color picker, and validation support for type=color.
Comment 1 Kent Tamura 2009-09-04 01:00:18 PDT
Created attachment 39044 [details]
Proposed patch
Comment 2 Eric Seidel 2009-09-04 01:21:50 PDT
Comment on attachment 39044 [details]
Proposed patch

I guess this is an OK start.  On Mac we'll want to use the NSColorWell I figure.  I don't see why it's useful to ever have a text box for color picking.
Comment 3 Eric Seidel 2009-09-04 01:32:58 PDT
Comment on attachment 39044 [details]
Proposed patch

Clearing flags on attachment: 39044

Committed r48043: <http://trac.webkit.org/changeset/48043>
Comment 4 Eric Seidel 2009-09-04 01:33:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Kent Tamura 2009-09-04 02:11:17 PDT
(In reply to comment #2)
> (From update of attachment 39044 [details])
> I guess this is an OK start.  On Mac we'll want to use the NSColorWell I
> figure.  I don't see why it's useful to ever have a text box for color picking.

Definitely.  We'll work on the UI.
Thank you very much for the quick review.