Bug 28965 - [V8] Crash when updating document cache
Summary: [V8] Crash when updating document cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-04 00:37 PDT by Mads Ager
Modified: 2009-09-04 01:09 PDT (History)
2 users (show)

See Also:

Attachments
Bail out if context initialization in updateDocument fails. (1.19 KB, patch)
2009-09-04 00:47 PDT, Mads Ager 		levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2009-09-04 00:37:45 PDT 
In some situations initialization of the JavaScript context can fail.  When that happens we cannot update the document cache.

This makes http/tests/security/javascriptURL/javascriptURL-in-new-iframe.html crash.
Comment 1 Mads Ager 2009-09-04 00:47:01 PDT 
Created attachment 39043 [details]
Bail out if context initialization in updateDocument fails.
Comment 2 David Levin 2009-09-04 01:00:41 PDT 
Comment on attachment 39043 [details]
Bail out if context initialization in updateDocument fails.

The changelog should mention that this is tested by -- and name the test that you mentioned in the bug.
Comment 3 David Levin 2009-09-04 01:01:38 PDT 
I'll fix the change log and land this.
Comment 4 David Levin 2009-09-04 01:09:19 PDT 
Committed as http://trac.webkit.org/changeset/48042