Bug 28963 - AX notifications should be an ENUM type instead of strings
Summary: AX notifications should be an ENUM type instead of strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-03 20:36 PDT by chris fleizach
Modified: 2009-09-09 23:41 PDT (History)
0 users

See Also:

Attachments
patch (15.09 KB, patch)
2009-09-08 22:21 PDT, chris fleizach 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-09-03 20:36:10 PDT 
right now AX notifications are string literals that match exactly with the strings used on the mac platform. it would be better to be an ENUM type that could then use public API
Comment 1 chris fleizach 2009-09-08 22:21:44 PDT 
Created attachment 39245 [details]
patch
Comment 2 Darin Adler 2009-09-09 07:42:40 PDT 
Comment on attachment 39245 [details]
patch

> +        // Notifications. Use strings provided for consistency.

What does "Use strings provided for consistency" mean? Who should use strings, for what?

> +        enum AXNotification {
> +            AXCheckedStateChanged = 1,

Why the = 1 here? I recommend leaving that out unless you have some need for a zero value.

r=me
Comment 3 chris fleizach 2009-09-09 23:41:08 PDT 
Committed rr48244: <http://trac.webkit.org/changeset/r48244>