WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28962
Remove unnecessary dependency on unistd.h in Completion.cpp
https://bugs.webkit.org/show_bug.cgi?id=28962
Summary
Remove unnecessary dependency on unistd.h in Completion.cpp
Yong Li
Reported
2009-09-03 19:31:22 PDT
Created
attachment 39032
[details]
the patch Why does Completion.cpp include "unistd.h"? It's not used at all.
Attachments
the patch
(908 bytes, patch)
2009-09-03 19:31 PDT
,
Yong Li
levin
: review+
levin
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2009-09-03 22:00:29 PDT
Comment on
attachment 39032
[details]
the patch r=me with one small fix below.
> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog > +
https://bugs.webkit.org/show_bug.cgi?id=(OOPS
!)
Please fill in the bug number when landing. It appears that this include was added for
http://bugs.webkit.org/show_bug.cgi?id=17339
due to the use of getpid() in this file but that function call is no longer present.
Yong Li
Comment 2
2009-09-04 07:02:19 PDT
landed @48048
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug