Bug 28962 - Remove unnecessary dependency on unistd.h in Completion.cpp
Summary: Remove unnecessary dependency on unistd.h in Completion.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-03 19:31 PDT by Yong Li
Modified: 2009-09-04 07:02 PDT (History)
2 users (show)

See Also:

Attachments
the patch (908 bytes, patch)
2009-09-03 19:31 PDT, Yong Li 		levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2009-09-03 19:31:22 PDT 
Created attachment 39032 [details]
the patch

Why does Completion.cpp include "unistd.h"? 

It's not used at all.
Comment 1 David Levin 2009-09-03 22:00:29 PDT 
Comment on attachment 39032 [details]
the patch

r=me with one small fix below.

> diff --git a/JavaScriptCore/ChangeLog b/JavaScriptCore/ChangeLog
> +        https://bugs.webkit.org/show_bug.cgi?id=(OOPS!)

Please fill in the bug number when landing.


It appears that this include was added for http://bugs.webkit.org/show_bug.cgi?id=17339 due to the use of getpid() in this file but that function call is no longer present.
Comment 2 Yong Li 2009-09-04 07:02:19 PDT 
landed @48048