Bug 28961 - [Qt] Fix tst_QWebPage::database autotest failure
Summary: [Qt] Fix tst_QWebPage::database autotest failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-03 19:31 PDT by Laszlo Gombos
Modified: 2009-09-04 00:50 PDT (History)
1 user (show)

See Also:


Attachments
proposed patch. (1.41 KB, patch)
2009-09-03 19:54 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-09-03 19:31:04 PDT
FAIL!  : tst_QWebPage::database() Compared values are not the same
   Actual (s1.toString()): 
   Expected (QString("This is a test for local storage")): This is a test for local storage
   Loc: [WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(426)]
Comment 1 Laszlo Gombos 2009-09-03 19:54:23 PDT
Created attachment 39034 [details]
proposed patch.

Test case broke after http://trac.webkit.org/changeset/47283 which disabled localStorage by default. Enable all the features that are tested explicitly to avoid this problem in the future.
Comment 2 Eric Seidel (no email) 2009-09-04 00:15:24 PDT
Comment on attachment 39034 [details]
proposed patch.

LGTM.
Comment 3 Eric Seidel (no email) 2009-09-04 00:24:26 PDT
Comment on attachment 39034 [details]
proposed patch.

Rejecting patch 39034 from commit-queue.  This patch will require manual commit.

['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1
Comment 4 Eric Seidel (no email) 2009-09-04 00:42:12 PDT
Comment on attachment 39034 [details]
proposed patch.

Yet another victim of bug 28845!
media/video-source-error.html -> crashed
Comment 5 Eric Seidel (no email) 2009-09-04 00:50:43 PDT
Comment on attachment 39034 [details]
proposed patch.

Clearing flags on attachment: 39034

Committed r48041: <http://trac.webkit.org/changeset/48041>
Comment 6 Eric Seidel (no email) 2009-09-04 00:50:48 PDT
All reviewed patches have been landed.  Closing bug.