RESOLVED FIXED 28953
WinLauncher MSVC project does not write buildfailed file on build failure 
https://bugs.webkit.org/show_bug.cgi?id=28953
Summary WinLauncher MSVC project does not write buildfailed file on build failure
Daniel Bates
Reported 2009-09-03 13:19:20 PDT
The Microsoft Visual C++ (VC) project file for WinLauncher does write the file buildfailed on a build failure because the project file does not specify any pre- and post- build events. Other VC project files have such build events. We should set these build events so that the WinLauncher project build process is consistent with the other project files.
Attachments
Patch (3.85 KB, patch)
2009-09-03 13:22 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2009-09-03 13:21:31 PDT
Is WinLauncher built as part of the WebKit solution?
Daniel Bates
Comment 2 2009-09-03 13:22:09 PDT
Created attachment 39005 [details] Patch
Daniel Bates
Comment 3 2009-09-03 13:23:14 PDT
Yes. (In reply to comment #1) > Is WinLauncher built as part of the WebKit solution?
Adam Roben (:aroben)
Comment 4 2009-09-03 13:49:05 PDT
Comment on attachment 39005 [details] Patch r=me
Adam Barth
Comment 5 2009-09-06 22:03:08 PDT
Assigned to dbates for landing.
Daniel Bates
Comment 6 2009-09-09 11:42:01 PDT
Comment on attachment 39005 [details] Patch Clearing flags on attachment: 39005 Committed r48218: <http://trac.webkit.org/changeset/48218>
Daniel Bates
Comment 7 2009-09-09 11:42:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.