Bug 28953 - WinLauncher MSVC project does not write buildfailed file on build failure
Summary: WinLauncher MSVC project does not write buildfailed file on build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-03 13:19 PDT by Daniel Bates
Modified: 2009-09-09 11:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.85 KB, patch)
2009-09-03 13:22 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-09-03 13:19:20 PDT
The Microsoft Visual C++ (VC) project file for WinLauncher does write the file buildfailed on a build failure because the project file does not specify any pre- and post- build events. Other VC project files have such build events. We should set these build events so that the WinLauncher project build process is consistent with the other project files.
Comment 1 Mark Rowe (bdash) 2009-09-03 13:21:31 PDT
Is WinLauncher built as part of the WebKit solution?
Comment 2 Daniel Bates 2009-09-03 13:22:09 PDT
Created attachment 39005 [details]
Patch
Comment 3 Daniel Bates 2009-09-03 13:23:14 PDT
Yes.

(In reply to comment #1)
> Is WinLauncher built as part of the WebKit solution?
Comment 4 Adam Roben (:aroben) 2009-09-03 13:49:05 PDT
Comment on attachment 39005 [details]
Patch

r=me
Comment 5 Adam Barth 2009-09-06 22:03:08 PDT
Assigned to dbates for landing.
Comment 6 Daniel Bates 2009-09-09 11:42:01 PDT
Comment on attachment 39005 [details]
Patch

Clearing flags on attachment: 39005

Committed r48218: <http://trac.webkit.org/changeset/48218>
Comment 7 Daniel Bates 2009-09-09 11:42:06 PDT
All reviewed patches have been landed.  Closing bug.