Bug 28927 - Fix DumpRenderTree build from clean tree on Tiger
Summary: Fix DumpRenderTree build from clean tree on Tiger
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-02 17:13 PDT by Cameron McCormack (:heycam)
Modified: 2009-09-08 11:03 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (1.88 KB, patch)
2009-09-02 17:16 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2009-09-02 17:13:43 PDT
A mkdir call is missing from a DumpRenderTree makefile that causes the DRT build to fail on Tiger.
Comment 1 Cameron McCormack (:heycam) 2009-09-02 17:16:51 PDT
Created attachment 38949 [details]
Patch v1
Comment 2 Darin Adler 2009-09-02 17:21:45 PDT
Comment on attachment 38949 [details]
Patch v1

Why make the dirname change?

r=me
Comment 3 Cameron McCormack (:heycam) 2009-09-02 17:26:59 PDT
(In reply to comment #2)
> Why make the dirname change?

Was just factoring out the directory name determination.  I guess I could have left the dirname call in the WRAPPER_DIR assignment.
Comment 4 Eric Seidel (no email) 2009-09-08 11:02:58 PDT
Comment on attachment 38949 [details]
Patch v1

Clearing flags on attachment: 38949

Committed r48170: <http://trac.webkit.org/changeset/48170>
Comment 5 Eric Seidel (no email) 2009-09-08 11:03:02 PDT
All reviewed patches have been landed.  Closing bug.