WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
28923
Table cell role should defer to WAI-ARIA role on cell, if set
https://bugs.webkit.org/show_bug.cgi?id=28923
Summary
Table cell role should defer to WAI-ARIA role on cell, if set
Jonas Klink
Reported
2009-09-02 15:37:24 PDT
In AccessibilityTableCell::roleValue() no check exists to see if a valid WAI-ARIA role attribute is set on the object. The expected behavior here would be for the WebCore::CellRole to defer to a valid ARIA role set on the object.
Attachments
Fixes the issue described in this bug.
(1.29 KB, patch)
2009-09-04 11:06 PDT
,
Jonas Klink
eric
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jonas Klink
Comment 1
2009-09-02 15:38:09 PDT
I will have a patch uploaded for review shortly.
Jonas Klink
Comment 2
2009-09-04 11:06:04 PDT
Created
attachment 39077
[details]
Fixes the issue described in this bug. Developer of patch is on Win-XP, where LayoutTests are still broken. LayoutTest should be added to test this behavior once they run properly on Win platform.
Darin Adler
Comment 3
2009-09-04 11:08:03 PDT
(In reply to
comment #2
)
> Developer of patch is on Win-XP, where LayoutTests are still broken. LayoutTest > should be added to test this behavior once they run properly on Win platform.
The Windows bot shows layout tests currently running fine with a few tests failing. I don't know what you mean by "LayoutTests are still broken". Could you refer me to the bugs.webkit.org bug describing the problem?
Jonas Klink
Comment 4
2009-09-04 11:15:10 PDT
Reason for that comment is that it looks like most of the tests are on the "Skipped" list (LayoutTests/platform/win/Skipped). If there is another reason for skipping all of these tests, I'd be happy to add a test to this patch.
Eric Seidel (no email)
Comment 5
2009-09-08 10:05:06 PDT
Comment on
attachment 39077
[details]
Fixes the issue described in this bug. We either need a test, or explanation as to why there is no test in the ChangeLog (ideally referencing a bug number). Jon Honeycutt might know more about AX tests and their status on XP.
Chris Guillory
Comment 6
2010-02-19 13:40:43 PST
Working with Jonas. I'll be picking up this patch.
James Craig
Comment 7
2013-09-30 12:16:43 PDT
Resolved in determineAccessibilityRole in a later rev.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug