RESOLVED INVALID 28917
Fix run-launcher to work for Qt Builds 
https://bugs.webkit.org/show_bug.cgi?id=28917
Summary Fix run-launcher to work for Qt Builds
Robert Hogan
Reported 2009-09-02 13:16:56 PDT
The run-launcher script depends on the existence of a file called 'Configuration' in the build directory to determine whether the build was debug or release. Fix the qmake build to create this file with the appropriate build information. Also fix the 'success' message to mention the '--qt' flag for run-launcher, since it won't run on most Qt build environments without it.
Attachments
Proposed Patch (3.46 KB, patch)
2009-09-02 13:22 PDT, Robert Hogan 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2009-09-02 13:22:09 PDT
Created attachment 38939 [details] Proposed Patch
Eric Seidel (no email)
Comment 2 2009-09-02 14:00:02 PDT
Comment on attachment 38939 [details] Proposed Patch This seems totally wrong. Configuration is created by "set-webkit-configuration". There are methods in webkitdirs.pm which know how to read the configuration and default to Release when it's not present.
Kenneth Rohde Christiansen
Comment 3 2009-10-04 07:39:54 PDT
The bug report seems invalid, can it be marked resolved?
Note You need to log in before you can comment on or make changes to this bug.