Bug 28917 - Fix run-launcher to work for Qt Builds
Summary: Fix run-launcher to work for Qt Builds
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2009-09-02 13:16 PDT by Robert Hogan
Modified: 2009-10-04 08:40 PDT (History)
1 user (show)

See Also:

Attachments
Proposed Patch (3.46 KB, patch)
2009-09-02 13:22 PDT, Robert Hogan 		eric: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2009-09-02 13:16:56 PDT 
The run-launcher script depends on the existence of a file called
        'Configuration' in the build directory to determine whether the
        build was debug or release. Fix the qmake build to create this file
        with the appropriate build information.

        Also fix the 'success' message to mention the '--qt' flag for
        run-launcher, since it won't run on most Qt build environments
        without it.
Comment 1 Robert Hogan 2009-09-02 13:22:09 PDT 
Created attachment 38939 [details]
Proposed Patch
Comment 2 Eric Seidel (no email) 2009-09-02 14:00:02 PDT 
Comment on attachment 38939 [details]
Proposed Patch

This seems totally wrong.

Configuration is created by "set-webkit-configuration".  There are methods in webkitdirs.pm which know how to read the configuration and default to Release when it's not present.
Comment 3 Kenneth Rohde Christiansen 2009-10-04 07:39:54 PDT 
The bug report seems invalid, can it be marked resolved?