Bug 28883 – [V8] FileList cannot be accessed via index in Chromium.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jian Li]

Need to fix V8 binding code to access the indexed property of FileList.

[Jian Li]

Created attachment 38877 [details]
Proposed Patch

[Dimitri Glazkov (Google)]

Comment on attachment 38877 [details]
Proposed Patch

r=me.

[David Levin]

Hmm.. twice reviewed :)

Consider fixing these on landing.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> [phone]  Jian Li  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [V8] FileList cannot be accessed via index in Chromium.
> +        https://bugs.webkit.org/show_bug.cgi?id=28883
> +
> +        The test is covered by clipboard-file-access.html.

Tested by clipboard-file-access.html.

> diff --git a/WebCore/bindings/v8/custom/V8FileListCustom.cpp b/WebCore/bindings/v8/custom/V8FileListCustom.cpp

> +#include "config.h"
> +#include "FileList.h"
> +
> +#include "File.h"

I don't understand why there is a blank line here.

> +
> +#include "V8Binding.h"
> +#include "V8CustomBinding.h"

> +INDEXED_PROPERTY_GETTER(FileList)
> +{
> +    INC_STATS("DOM.FileList.IndexedPropertyGetter");
> +    FileList* imp = V8DOMWrapper::convertToNativeObject<FileList>(V8ClassIndex::FILELIST, info.Holder());

Use full words for variables "imp".  Perhaps "fileList" instead?

> +    RefPtr<File> result = imp->item(index);

"result" doesn't sound like a very descriptive variable name.
How about "file"?

[Jian Li]

All fixed and committed as http://trac.webkit.org/changeset/47947.